Fixes #15274: Handle errors in log filter #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
changed the title
|
PR updated with a new commit |
peckpeck
reviewed
Jul 23, 2019
| @@ -149,7 +149,7 @@ lint: | |||
|
|
|||
| check: lint | |||
| cd relayd && cargo test | |||
| cd relayd && cargo audit | |||
| cd relayd && cargo audit --ignore RUSTSEC-2019-0011 #https://github.com/crossbeam-rs/crossbeam/issues/401 | |||
There was a problem hiding this comment.
To temporarily ignore the security alert and make the tests pass, I'll open an issue to remove it once fixed upstream.
peckpeck
approved these changes
Jul 23, 2019
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
amousset
force-pushed
the
arch_15274/handle_erreors_in_log_filter
branch
from
02b71b4
to
1136b1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/15274